Since it looks like your PR has 25 files in it, I'll have to find time to go through and figure out what is/isn't needed - if you could try and issue PRs for smaller bits at once (eg. Generally people send PRs for small things at once - one module and the docs for it. modules/codeNeopixelEx3.js and it looks like a few other files, that seem to be snippets of code you're using for testing?.Looking at the diffs in your case, you'd probably need to remove a few extra files you have there: Once you have done it, the answer is really 'it depends' - simple stuff can get merged within a few minutes, otherwise it can take a few days - weeks if I'm busy. If you clicked new pull request while looking at the master branch (or the one you care about) then it should give you the option of creating a pull request on the main repo. It looks from your fork cs/branches (is that you?) that you created a branch and merged it into your fork. If you look at /pulls you'll see that there is no Pull request from you there. I think you created a pull request on your own personal fork? Thanks for any kind thoughts and words of wisdom. Are horses out of the question during pinning of the OBE and 21 cannon salute? How long is the red carpet? Black tie and tails? and how large a band should I consider? Black Dyke Mills from the sixties (Jim Shepherd) my favorite. and what/where should I be looking out for? Where am I able to get feedback on the process at GitHub?. Is there a way to review the actual original pull request? If everything is going as planned, about how long is the normal cycle time, as I guess there is a review and sanitizing step in the works, before finalization? I think I'm on the right track as if I go to:Īnd attempt a pull request, I can only push files which agrees with the 'Writing+Modules' content, not mentioning the word 'push' This then implies, that my process is what was intended to have happened. Did I goof somewhere and create a pull action into my own /EspruinoDocs copy? So, is this the master folder of my forked copy or the master folder of espruino/EspruinoDocs ?Į.g. Merged commit 14618de into master 2 days ago I can get to a page that indicates I did something, but unable to see what it is I actually did. If I navigate back to the pull request page from two days ago, Should I inspect the Pull Requests tab, I see 0 Open 1 Closed which is a bit mis-leading as Is the pull process closed on the request I made, meaning no further action is/will to be taken or just an ack that the files are in the pipeline, so the I waited 48 hours before creating this forum post as not to show too much impatience. Where/how do I obtain feedback on a pull-request at GitHub?Īttempting to get/understand feedback on the submittal/approval process after following the above steps.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |